pay: still use channels for routehints even if peer says it's disabled. #6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a report that LND said our (unannounced) channel was disabled, so we didn't use it for routehints. We're better off ignoring that in this case (if the peer is actually not connected, the routehint code will check that and ignore anyway). Fixes: ElementsProject#6555 Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: pay: use channels in routehints even if peer says they're "disabled" (LND compat)
rustyrussell
added
lnd-compat
protocol
There was a problem hiding this comment.
This LGTM but the CI looks like that catch somethings
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_opening.py::test_rbf_broadcast_close_inflights - AssertionError: assert '0446f4874120bebf7f20e378010b3602fee31274f8903dad7570e6bf5b4714a5' in ['5a74e9f4b30c81ddc3996f748a6909875694faa2cf13d516058a484b8fe593e3']
+ where ['5a74e9f4b30c81ddc3996f748a6909875694faa2cf13d516058a484b8fe593e3'] = <function SimpleBitcoinProxy.__getattr__.<locals>.f at 0x7fe35e04af70>()
+ where <function SimpleBitcoinProxy.__getattr__.<locals>.f at 0x7fe35e04af70> = <pyln.testing.utils.SimpleBitcoinProxy object at 0x7fe35e04e460>.getrawmempool
+ where <pyln.testing.utils.SimpleBitcoinProxy object at 0x7fe35e04e460> = <pyln.testing.utils.BitcoinD object at 0x7fe35e03de50>.rpc
Not sure if this is unrelated but it does not seems flaky test
Seems unrelated: the topology and on-chain footprint have not changed, so why would we suddenly fail to see an on-chain transaction? |
No idea :) I just post the CI failure because I was travelling and I was not able a sanity check in the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a report that LND said our (unannounced) channel was disabled, so we didn't use it for routehints. We're better off ignoring that in this case (if the peer is actually not connected, the routehint code will check that and ignore anyway).
Fixes: #6555
Changelog-Changed: pay: use channels in routehints even if peer says they're "disabled" (LND compat)