Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rune db ids #6640

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Fix rune db ids #6640

merged 3 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. pytest: test to show that we got db ids incorrect. 

    Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b7f9124 View commit details
    Browse the repository at this point in the history

  2. runes: insert rune with correct id field. 

    "id" is a magic name, so it was being populated by sqlite3
automatically, starting at 0.  Fortunately, we only fetched by id in
one place: to indicate the `stored` flag when asked about an explicit
rune in `showrunes`.

Reported-by: @ShahanaFarooqui
Signed-off-by: Rusty Russell <[email protected]>
Changelog-Fixed: JSON-RPC: `showrunes` on a specific rune would always say `stored`: false.
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    496a6a8 View commit details
    Browse the repository at this point in the history

  3. db: migrate old runes table to fix up id fields. 

    Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f67e7b0 View commit details
    Browse the repository at this point in the history