[cln-rpc]: add Eq, PartialOrd, Ord, Hash to ShortChannelId #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
ACK 5cf310f
I do not think this will create any problem you are just making ShortChannelId comparable as u64 (?)
|
ACK 5cf310f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this can be problematic, but it would be nice to have so i can do things like comparison,
sort_by(|x| x.scid)or scids as keys inHashMap/BTreeMapwithout converting them toStringfirst.