cln-grpc: Patches rpc-file path #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the issue with Polar is on the Polar/docker side, the issue with the workaround is on CLN 😅 |
vincenzopalazzo
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
ACK 5608509
This make sense I do not know how this was working before? maybe there is something that was implicit assumed by let path = Path::new("lightning-rpc");
|
ACK 5608509 |
cdecker
force-pushed
the
20231103-fix-clngrpc-rpc-file-path
branch
from
5608509
to
41cb263
Compare
|
Rebased on top of master, and merging as soon as CI passes. |
cdecker
force-pushed
the
20231103-fix-clngrpc-rpc-file-path
branch
2 times, most recently
from
caedac8
to
9cbcd91
Compare
`cln-gprc` is assuming the `rpc-file` path is set as default, which may not always be the case. Set the path the what the plugin manager reports
cdecker
force-pushed
the
20231103-fix-clngrpc-rpc-file-path
branch
from
9cbcd91
to
af8b189
Compare
|
Rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cln-gprcis assuming therpc-filepath is set as default, which may not always be the case. Set the path the what the plugin manager reportsContext
Lately, Polar for macOS has been unable to deploy CLN nodes due to an issue with how the
rpc-fileis generated on the docker volume (see jamaljsr/polar#779 for details). Recently, a workaround has been found, consisting of moving therpc-fileoutside of its default location. However, doing so makescln-grpcunable to connect to the backend.This can be worked around by creating a simlink in the default location to point to where
lightning-rpcis actually located. However, the underlying issue lies incln-grpcnot getting the info fromcln-pluginbut instead, assuming the location of the file.