lightningd: log BROKEN if we lost funds, only unusual if we closed abandoned HTLC #7364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
Merged
…andoned HTLC. Started seeing these in my logs, and it's the wrong way around! Signed-off-by: Rusty Russell <[email protected]>
…incoming already onchain. From test_penalty_htlc_tx_timeout[False] flake (with keys replaced by l2 and l5, for clarity) ``` lightningd-3 2024-06-04T04:34:00.942Z UNUSUAL l2-chan#1: Peer permanent failure in CHANNELD_NORMAL: Funding transaction spent lightningd-3 2024-06-04T04:34:01.570Z UNUSUAL l5-chan#3: Peer permanent failure in CHANNELD_NORMAL: Funding transaction spent lightningd-3 2024-06-04T04:34:01.655Z UNUSUAL l5-chan#3: Abandoning unresolved onchain HTLC at block 132 (expired at 125) to avoid peer closing incoming HTLC at block 131 lightningd-3 2024-06-04T04:34:02.802Z **BROKEN** l5-chan#3: FUNDS LOSS of 50000000msat: peer took funds onchain before we could time out the HTLC, but we abandoned incoming HTLC to save the incoming channel ``` So, we were already closing l2, no reason to abandon it. Signed-off-by: Rusty Russell <[email protected]>
ShahanaFarooqui
force-pushed
the
warning-missing-htlc
branch
from
a3b59fe
to
5a2453a
Compare
|
ACK 5a2453a |
vincenzopalazzo
merged commit 1a1696f
into
ElementsProject:master
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started seeing these in my test logs, and it's the wrong way around!
Also, fixes flake in test_penalty_htlc_tx_timeout[True]