Connectd speed up #1: spend less time polling. #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rustyrussell
force-pushed
the
connectd-optimize
branch
from
50b7a4a
to
cb176b0
Compare
A fairly simple change: ccan/io will now call the underlying I/O routines repeatedly until they indicate they are unfinished, *or* fail with EAGAIN. This should make a significant difference to large nodes, which currently spend far too much time calling poll() to discover a single fd is still writable (mainly, for streaming gossip). Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: connectd: now should use far less CPU on large nodes.
Interestingly, this patch and the last take my total test time on my build machine down by about 10%. From 403.93s (0:06:43) to 366.64s (0:06:06) though there were some unrelated errors. Changelog-Changed: connectd: I/O optimizations to significantly speed up larger nodes. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
connectd-optimize
branch
from
cb176b0
to
5abc184
Compare
niftynei
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Concept ACK 5abc184
LGTM but I want to rerun the CI for regression if any
ShahanaFarooqui
merged commit eb1c04e
into
ElementsProject:master
30 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly simple change: ccan/io will now call the underlying I/O
routines repeatedly until they indicate they are unfinished, or fail
with EAGAIN. This should make a significant difference to large
nodes, which currently spend far too much time calling poll() to
discover a single fd is still writable (mainly, for streaming gossip).
Changelog-Changed: connectd: now should use far less CPU on large nodes.
Fixes: #7243