BOLT catchups for v24.08 #7388
Merged
BOLT catchups for v24.08 #7388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/bolt-catchup-25.0
branch
3 times, most recently
from
371ec9b
to
6020f2f
Compare
…OUTING_SYNC. This means we do have to set the network correctly though, and also we can get query messages from lightningd which we have to filter. Signed-off-by: Rusty Russell <[email protected]>
…e out of sync. Just use substrings not regexes, since we have more complex characters now LaTeX is entering the spec! Signed-off-by: Rusty Russell <[email protected]>
…ipient_data with both scid and node. Signed-off-by: Rusty Russell <[email protected]>
Soo.... pretty.... Signed-off-by: Rusty Russell <[email protected]>
We still support *existing* channels. Just not new ones (before they could, in theory, explicitly ask for one). Signed-off-by: Rusty Russell <[email protected]>
…only!) non-zero-fee anchor channels. These were removed from the spec. We still support existing ones, though we were the only implementation which ever did, and only in experimental mode, so we should be able to upgrade them and avoid a forced close, with a bit of engineering... Signed-off-by: Rusty Russell <[email protected]>
…ption_anchors". This is a difficult transition for us: this string appears in channel types. We make the transition now in the understanding that it will be more difficult in future. Signed-off-by: Rusty Russell <[email protected]> Changelog-Deprecated: JSON-RPC: `listpeers` `features` array string "option_anchors_zero_fee_htlc_tx": use "option_anchors" (spec renamed it). Changelog-Added: JSON-RPC: `listpeers` `features` array string uses "option_anchors" for feature 22/23, following renaming in BOLT 9. Changelog-Changed: JSON-RPC: `listclosedchannels`, `listpeerchannels`, `openchannel_update`, `openchannel_init`, `fundchannel`, `fundchannel_start` and `multifundchannel`: `channel_type` array `names` now contains "anchors" instead of "anchors_zero_fee_htlc_tx". Changelog-Changed: lightningd: `--list-features-only` now lists "option_anchors" instead of "option_anchors_zero_fee_htlc_tx".
We have assumed this for a long time, so nothing changes. Confusingly, this BOLT commit also cleaned up one reamining `option_anchors_zero_fee_htlc_tx`. Signed-off-by: Rusty Russell <[email protected]>
Everyone understands gossip_queries now, but peers leave it unset to indicate they have nothing useful to say. Signed-off-by: Rusty Russell <[email protected]>
Everyone sends a gossip_timestamp_filter message these days to start gossip. Signed-off-by: Rusty Russell <[email protected]>
…lost data. We could get the current key from the reestablish message even if we'd lost our db, but there are very few of these channels left: we upgraded to use them in the 2019-01-09 release. We will eventually remove support altogether, but this is a nice removal of some ugly code for something which "never happens". Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bolt-catchup-25.0
branch
from
6020f2f
to
6ae129d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, some old features can be assumed now, so this does simplify the code somewhat. We still support them for existing channels, however.