Fix gossip update propagation #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't actually check that we *send* the refreshed gossip, just that we print the message saying we're going to. So check that everyone received updated gossip when this happens. Signed-off-by: Rusty Russell <[email protected]>
In particular, those who've filtered it out. This currently fails, as expected. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
added
gossip
Highlight - Stability and Security
We're going to need this for the next commit. Signed-off-by: Rusty Russell <[email protected]>
When a peer connects, we always send all our own gossip (even if they had set the timestamp filters to filter it out). But we weren't forcing it out to them when it changed, so this logic only applied to unstable or frequently-restarting nodes. So now, we tell all the peers whenever we tell gossipd about our new gossip. Fixes: ElementsProject#7276 Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: Protocol: We now send current peers our changed gossip (even if they set timestamp_filter otherwise), not just on reconnect.
rustyrussell
force-pushed
the
guilt/gossip-refresh
branch
from
8d4f61f
to
7a733d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't force-propagate new gossip to our peers as it happened, only on reconnect.