Fix plugin startup crash #7673
Merged
Fix plugin startup crash #7673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We modify broken.py to be able to fail at different points, and test that during startup. Signed-off-by: Rusty Russell <[email protected]>
Thanks to Michael Schmook for the excellent bug report. Fixes: ElementsProject#7671 Changelog-Fixed: lightningd: no longer crash if a plugin dies during lightningd startup. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/plugin-startup-crash
branch
from
3dcd01a
to
e13d34c
Compare
m-schmoock
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
ACK e13d34c
Thanks. Does what its supposed to do.
Now I know it was the backup plugin that crashed with
2024-09-17T06:20:27.651Z UNUSUAL plugin-backup-cli: Killing plugin: Invalid/missing result tok in '{"jsonrpc": "2.0","id": 19,"error": {"code":-4, "message":"Plugin terminated before replying to RPC call."}}'
Anyway, the daemon was able to do the database update and the backup plugin came online just normal after that.
The test runs fine on my development machine ( x86_64 ) but I can't run it on the Raspberry ( aarch64 ) likely for unrelated reasons:
FAILED tests/test_plugin.py::test_plugin_fail_on_startup - jsonschema.exceptions.ValidationError: 0msat is not of type 'msat
|
Ah nevermind, found out the issue on my Raspberry. It was using the 23.0.8 pyln-client for some reason and the v24 pyln-testing |
|
ACK e13d34c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @m-schmoock for the excellent bug report.
Fixes: #7671