Re-add -Zsymbol-mangling-version=v0.

EmbarkStudios · Aug 27, 2021 · 5ca1e1c · 5ca1e1c
1 parent c3cb849
commit 5ca1e1c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/rustc_codegen_spirv/Cargo.toml b/crates/rustc_codegen_spirv/Cargo.toml
@@ -39,7 +39,7 @@ ar = "0.9.0"
 bimap = "0.6"
 indexmap = "1.6.0"
 rspirv = "0.10"
-rustc-demangle = "0.1.18"
+rustc-demangle = "0.1.21"
 sanitize-filename = "0.3"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"

diff --git a/crates/spirv-builder/src/lib.rs b/crates/spirv-builder/src/lib.rs
@@ -391,8 +391,7 @@ fn invoke_rustc(builder: &SpirvBuilder) -> Result<PathBuf, SpirvBuilderError> {
 
     let mut rustflags = vec![
         format!("-Zcodegen-backend={}", rustc_codegen_spirv.display()),
-        //FIXME: reintroduce v0 mangling, see issue #642
-        "-Zsymbol-mangling-version=legacy".to_string(),
+        "-Zsymbol-mangling-version=v0".to_string(),
     ];
 
     let mut llvm_args = vec![];

diff --git a/tests/src/main.rs b/tests/src/main.rs
@@ -292,6 +292,7 @@ struct TestDeps {
 }
 
 /// The RUSTFLAGS passed to all SPIR-V builds.
+// FIXME(eddyb) expose most of these from `spirv-builder`.
 fn rust_flags(codegen_backend_path: &Path) -> String {
     [
         &*format!("-Zcodegen-backend={}", codegen_backend_path.display()),
@@ -300,6 +301,7 @@ fn rust_flags(codegen_backend_path: &Path) -> String {
         "-Cdebuginfo=2",
         "-Cembed-bitcode=no",
         "-Ctarget-feature=+Int8,+Int16,+Int64,+Float64",
+        "-Zsymbol-mangling-version=v0",
     ]
     .join(" ")
 }

diff --git a/tests/ui/dis/generic-fn-op-name.stderr b/tests/ui/dis/generic-fn-op-name.stderr
@@ -7,7 +7,7 @@ OpMemoryModel Logical Simple
 OpEntryPoint Fragment %1 "main"
 OpExecutionMode %1 OriginUpperLeft
 %2 = OpString "$OPSTRING_FILENAME/generic-fn-op-name.rs"
-OpName %3 "generic_fn_op_name::generic"
+OpName %3 "generic_fn_op_name::generic::<f32, {spirv_types::image_params::Dimensionality::TwoD}>"
 OpName %4 "generic_fn_op_name::main"
 %5 = OpTypeVoid
 %6 = OpTypeFunction %5