Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SPIR-T for better pretty-printing (esp. OpExtInst), and started deduplicating custom debuginfo. #1083

Merged
merged 9 commits into from
Jul 25, 2023

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Jul 24, 2023

Potentially relevant SPIR-T PRs that are included here:

That last one is the most relevant here, because together with debuginfo deduplication, it causes:

Before After
image

Yes, that's the same function (sky_shader::henyey_greenstein_phase), but incomprehensible before.

@eddyb eddyb requested review from fu5ha, repi and VZout July 24, 2023 16:11
@eddyb eddyb enabled auto-merge (rebase) July 24, 2023 16:13
@eddyb eddyb merged commit 9002209 into EmbarkStudios:main Jul 25, 2023
7 checks passed
@eddyb eddyb deleted the spirt-update-minimal branch July 25, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants