Add trunc and fract to MathExt #222
Conversation
fu5ha
added
c: spirv-std
There was a problem hiding this comment.
neat! this commit is included in the other PR, so github might get a little confused here, but yeah~
also looks like the commit hash in
Line 19 in bfa0f50
spirv branch is for CI to pass (I'm guessing someone force-pushed the branch)
Cargo.toml
Outdated
| @@ -16,4 +16,4 @@ members = [ | |||
|
|
|||
| [patch.crates-io] | |||
| # https://github.com/bitshifter/glam-rs/pull/85 | |||
| glam = { git = "https://github.com/EmbarkStudios/glam-rs", rev = "d55ff75e91aab01c4fd9808e3ca9c079dfa7315c" } | |||
| glam = { git = "https://github.com/EmbarkStudios/glam-rs", branch = "spirv" } | |||
There was a problem hiding this comment.
Probably want to rebase onto #220 since that will conflict with this change.
crates/spirv-std/src/lib.rs
Outdated
| @@ -39,8 +39,6 @@ | |||
| mod math_ext; | |||
| pub use math_ext::MathExt; | |||
|
|
|||
| pub use glam; | |||
There was a problem hiding this comment.
@XAMPPRocky explicitly added this in #220, so we should figure out if we want this or not (I said 👍 to her adding it, so I think we should keep it).
Also, there's some issues with overriding versions in cargo.toml, in particular people referencing crates through a git reference will not pick up the workspace override, so keeping the override in the crate instead of the workspace is good.
edit: oh, sorry, missed the recent conversation in 220. Let's talk about it in the meeting today.
|
Okay, so based on meeting convo, I reverted back to pub use glam for now, pending figuring out how we can upstream to glam. Will just be using patching in ark/macaw for now. |
|
@Mergifyio refresh |
|
Command
|
Does what it says on the tin ;)