Add vector_insert_dynamic #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyperia
approved these changes
Feb 10, 2021
XAMPPRocky
changed the title
XAMPPRocky
commented
Feb 10, 2021
XAMPPRocky
force-pushed
the
composite-arch
branch
2 times, most recently
from
6aa874c
to
5ab9aee
Compare
eddyb
suggested changes
Feb 11, 2021
Comment on lines
374
to
376
| // FIXME(eddyb) missing equality constraint between input and output vectors. | ||
| (Vector(T), T, _) -> Vector(T) | ||
| // (Vector(T), T, _) -> Vector(T) | ||
| (T, _, _) -> T |
There was a problem hiding this comment.
LGTM, mind changing the comment to something like this? just so it's super clear what's going on:
// FIXME(eddyb) was `(Vector(T), T, _) -> Vector(T)` but that was
// missing an equality constraint between input and output vectors;
// we should use `(Vector(T, N), T, _) -> Vector(T, N)`, or constrain
// input and output vectors to have the same type some other way.
(T, _, _) -> T
XAMPPRocky
force-pushed
the
composite-arch
branch
from
5ab9aee
to
ca6f98c
Compare
eddyb
reviewed
Feb 11, 2021
| asm! { | ||
| "%vector = OpLoad _ {vector}", | ||
| "%element = OpLoad _ {element}", | ||
| "%new_vector = OpVectorInsertDynamic _ %vector %element {index}", |
There was a problem hiding this comment.
cc @msiglreith this works now 🎉
eddyb
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new simple instructions to the arch module that map to
OpVectorInsertDynamicandOpCopyObjectinstructions.