Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak CI (fix control_barrier and memory_barrier tests). #577

Closed
wants to merge 1 commit into from

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Apr 5, 2021

#519 was landed with a stale (2 week old at this point) CI, predating the introduction of Vulkan validation on CI, and now main itself doesn't pass CI anymore.

I don't like my Semantics bodge, but it being a bitset means using enum is just wrong.

I could've switched it to bitflags! but it seemed easier to just work around it for now.

@eddyb
Copy link
Contributor Author

eddyb commented Apr 5, 2021

Well, this is awkward but it landed when @termhn approved #576.

@eddyb eddyb closed this Apr 5, 2021
auto-merge was automatically disabled April 5, 2021 18:41

Pull request was closed

@khyperia khyperia removed their request for review May 31, 2021 09:26
@eddyb eddyb deleted the fix-ci branch November 25, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant