Add shader image query instructions #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
approved these changes
Apr 29, 2021
| /// 3D, or Cube, it must have *either* multisampled be true, *or* sampled of Unknown or No. | ||
| #[crate::macros::gpu_only] | ||
| #[doc(alias = "OpImageQuerySize")] | ||
| pub fn query_size<Size: ImageCoordinate<u32, DIM, ARRAYED> + Default>(&self) -> Size { |
There was a problem hiding this comment.
ImageCoordinate itself could probably require all implementations to also have Default as the only valid image coordinate types are vectors and scalars all of which impl Default.
XAMPPRocky
approved these changes
Apr 29, 2021
XAMPPRocky
approved these changes
Apr 30, 2021
eddyb
approved these changes
Apr 30, 2021
XAMPPRocky
pushed a commit
that referenced
this pull request
May 3, 2021
* Add shader image query instructions * Normalize spirv-std src paths in test output * Fix tests on vulkan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticks some more boxes off in #204