Add is_helper_invocation, and cleanup arch & asm functions #612
Conversation
XAMPPRocky
force-pushed
the
cleanup
branch
2 times, most recently
from
41809a4
to
eda58b4
Compare
| /// non-uniform) and does not terminate the block. | ||
| /// | ||
| /// - **Required Capabilities** `DemoteToHelperInvocationEXT` | ||
| /// - **Required Extensions** `SPV_EXT_demote_to_helper_invocation` |
There was a problem hiding this comment.
Turning these into #[cfg] on the method would be nice and is something we should do eventually, but not required right now. (Same thing on derivatives, etc.)
There was a problem hiding this comment.
Yeah, and I think we'd want to do more than #[cfg], as when it's cfg'ed out, the error will just be "demote_to_helper_invocation not found", when ideally the error message would tell you, you need those capabilities and extensions.
There was a problem hiding this comment.
... as in, doing a custom cfg attribute? we already decided against that in our discussions though, I'm confused
There was a problem hiding this comment.
I'm not sure how it would be exactly, but I meant more like a macro which just expands to two versions of the function containing the cfg and a better message similar to gpu_only.
Cleaning up and removing all the asm uses of
OpCapability, and also addedis_helper_invocation, also madedemote_to_helper_invocationunsafe, as using it has side effects that make variables undefined.