Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit bindless and kernel modes #710

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

khyperia
Copy link
Contributor

@khyperia khyperia commented Aug 9, 2021

As discussed in the meeting, remove bindless mode and kernel mode, as they're unfortunately not directions that we want to head in.

Note that "bindless mode" does not refer to actually supporting bindless itself, but rather a strongly opinionated system of features that enforced all rust-gpu programs use bindless, with no option of "normally" bound resources. Bindless is still very much a feature we want to support first-class, but we want to make more incremental changes towards making bindless easier to write, rather than dropping support for non-bindless systems. (We already support bindless in the regular, non-"bindless mode" model, and will continue to support it after this PR)

@khyperia khyperia requested a review from eddyb as a code owner August 9, 2021 13:23
@khyperia khyperia changed the title Remove bindless kernel Remove bindless and kernel modes Aug 9, 2021
@repi
Copy link
Contributor

repi commented Aug 9, 2021

Should we clarify in the title and description that it is the implicit bindless mode (or some other name for it?) this is referring to, standard bindless with explicit resources that you manage yourselves is still fully possible and something we use in Ark as well.

@khyperia
Copy link
Contributor Author

khyperia commented Aug 9, 2021

Should we clarify in the title and description that it is the implicit bindless mode (or some other name for it?) this is referring to, standard bindless with explicit resources that you manage yourselves is still fully possible and something we use in Ark as well.

Ah yeah, probably! Edited the description, but not sure how to concisely say that in the title (feel free to edit), I'm too deep in the technical weeds to think of something understandable to folks not in the pit of shenanigans :P

@repi
Copy link
Contributor

repi commented Aug 9, 2021

Thanks fair enough, think we can call the old mode that is removed here "implicit bindless" as it did implicitly create resources for bindless access.

That said - "bindless" is a stupid word as well :)

@repi repi changed the title Remove bindless and kernel modes Remove implicit bindless and kernel modes Aug 9, 2021
@khyperia khyperia merged commit 12c09cb into main Aug 10, 2021
@khyperia khyperia deleted the remove-bindless-kernel branch August 10, 2021 06:23
@Jasper-Bekkers
Copy link
Contributor

This removal is really unfortunate and is kind of forcing us to have to maintain a fork of the project :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants