Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SampledImage::sample_by_lod #755

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

expenses
Copy link
Contributor

This resolves the issue I was having in #754. I'd be good to get all the other sampling functions implemented for SampledImage as well, but let's start with this one.

@expenses expenses changed the title Add 'SampledImage::sample_by_lod' Add SampledImage::sample_by_lod Sep 25, 2021
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add compiletests - otherwise, looks good!

@expenses expenses requested a review from khyperia October 1, 2021 12:50
@khyperia khyperia merged commit 4e5f347 into EmbarkStudios:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants