Add option to disable RTS on Windows

[kealist]

Regarding #1276 I was trying to add this option. I am not familiar with getting grunt working, but I'll go ahead and push this and test it once I figure out how. Thanks

[reconbot]

(We don't use grunt?)

This looks good, will give it a test and then probably a merge! Thank you so much!

[kealist]

Regarding Grunt from Contributing.MD

Submitting Pull Requests

To contribute code to SerialPort, fork the project onto your github account and do your work in a branch. Before you submit the PR, make sure to rebase master into your branch so that you have the most recent changes and nothing breaks or conflicts. Lint and test your code using grunt. Also squash your commits to a reasonable size before submitting.

I can try to add the other options if I get a minute tonight.

[reconbot]

Thanks! And I'll fix that doc bug! Haven't used grunt in a while.

…

On Fri, Aug 4, 2017, 5:48 PM Joshua Shireman ***@***.***> wrote: Regarding Grunt from Contributing.MD Submitting Pull Requests To contribute code to SerialPort, fork the project onto your github account and do your work in a branch. Before you submit the PR, make sure to rebase master into your branch so that you have the most recent changes and nothing breaks or conflicts. Lint and test your code using *grunt.* Also squash your commits to a reasonable size before submitting. I can try to add the other options if I get a minute tonight. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1277 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlbrwOCv-4PCcVv2I3owqh-63Lx5CUks5sU5HDgaJpZM4Or6fL> .

[kealist]

I gave up on xany because there isn't anything that seems to directly map from termios to the Windows-side.

[reconbot]

@kealist we can have binding specific options that we can pass when you want to use them. It sounds like it would make sense to put xany there. I'm not sure how to elegantly handle the fact that option would exist two places.

This PR is good! I have a question about releasing it. This looks like it will change the default behavior.

In our open settings rtscts defaults to false, but we had hard coded to RTS_CONTROL_ENABLE which is true. I'm surprised this hasn't come up on my radar before as these are two very different modes. Is RTS not really important in most USB serial devices or something?

[kealist]

It is my understanding that USB-based traditional serial devices generally are less likely to use it, so I think disabled by default is probably better, but I'm not 100% sure.

[kealist]

In terms of node modules updating, will I see this patch if I update the serialport node module (i.e. does it pull code straight from github), or would I have to wait for an official release? I tried to find the answer but don't see anything clearly.

[reconbot]

It's up to you. I'll have a beta release before the next official release where you can test this and a few other changes out. This change is major enough we'll have to do a 6x release.

You can install the latest stable via npm install serialport the latest beta via npm install serialport@beta and from github with npm install EmergingTechnologyAdvisors/node-serialport. You can find more info at npm's docs. https://docs.npmjs.com/cli/install#synopsis

[kealist]

Seems getting the build system up on this old netbook isn't working smoothly, so I'll have to wait for beta

[reconbot]

[email protected] released

[kealist]

Thank you for the release. I'm currently getting bogus data (write 0x8184 out the serial port, but it is spitting out 0xFEFE) Trying to make sure it's not something on my side (but it used to be correct with previous release)