Added unspent output data structure #165
Conversation
|
@alessandrokonrad Ah yes, thanks for pointing this out. This was an oversight when I was drafting the first version of the spec. It was based on the ergo one which the regular output was enough to create an input out of. The CIP spec is not joined with this library directly so we're going to need to specify a way in that spec first that is implementation-independent. The spec so far directly refers to the shelley-ma.cddl binary spec so we should ideally specify a nice way for UTXOs that contains enough info for it to be useful in all use-cases. What you have in this PR seems like a solid choice but we should update the spec first as it currently references the following cddl: |
rust/src/utils.rs
Outdated
| #[derive(Clone, Debug)] | ||
| pub struct TransactionUnspentOutput { | ||
| input: TransactionInput, | ||
| value: Value, |
There was a problem hiding this comment.
Is there a reason to specify value and address instead of just using output: TransactionOutput?
There was a problem hiding this comment.
I oversaw that with TransactionOutput, your solution makes more sense right.
There was a problem hiding this comment.
I updated the CIP with this change using the cddl
transaction_unspent_output = [
input: transaction_input,
output: transaction_output,
]
alessandrokonrad
force-pushed
the
utxo_data
branch
from
0880250
to
53b3a96
Compare
The proposed Dapp connector https://github.com/cardano-foundation/CIPs/pull/88/files
requires an unspent output data structure in cbor.