Ed25519Key crv field has incorrect value #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Emurgo#9 Due to how wasm_bindgen works direct enums were not allowed so the rust values of enums are NOT what their value when converted to `Label`. This rust value was used in the `crv` field of the `Ed25519Key` builder by accident.
|
@vsubhuman does it make sense to add me as a maintainer of this crate too like we did with the serialization lib? |
vsubhuman
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Due to how wasm_bindgen works direct enums were not allowed so the rust
values of enums are NOT what their value when converted to
Label. Thisrust value was used in the
crvfield of theEd25519Keybuilder byaccident.