Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EmIP6 - Reputation endpoint #1329

Conversation

SebastienGllmt
Copy link
Contributor

@SebastienGllmt SebastienGllmt commented Jan 31, 2020

The reputation endpoint is meant to be a way for users to pick curators for extra metadata about pools such as location, trustworthiness, etc.

For the first version in Yoroi, we don't have any curators (or the ability to add more) and instead start by just forwarding to Yoroi information about pool behavior based on on-chain data.

If our node detects issues with a pool, we now show a red warning next to the pool name
image

We use a bitset to indicate possible issues

Ex: 1 issue detected
image

Ex: multiple issues detected
image

If an issue is forwarded from our node but Yoroi doesn't know what it is (due to version mismatch) we just show a generic error
image

@SebastienGllmt SebastienGllmt added the small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage label Jan 31, 2020
@SebastienGllmt SebastienGllmt self-assigned this Jan 31, 2020
@SebastienGllmt SebastienGllmt merged commit c1103b2 into shelley Feb 1, 2020
@SebastienGllmt SebastienGllmt deleted the sebastiengllmt/ch2386/warning-if-delegating-to-a-pool-in-the-blacklist branch February 1, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant