Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Yoroi-lib UtxoService to manage utxo set for Cardano wallets #2857

Merged
merged 37 commits into from
Dec 6, 2022

Conversation

yushih
Copy link
Collaborator

@yushih yushih commented May 26, 2022

Important reminder: I assume this will be released in version 4.14 so I use this value in the migration code (adaMigration.js). Should it not be the case, the value in the code needs to be changed accordingly.

@yushih yushih marked this pull request as ready for review May 30, 2022 02:46
@vsubhuman vsubhuman self-requested a review June 2, 2022 12:42
@vsubhuman vsubhuman added this to the 4.18.0 milestone Oct 13, 2022
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@yushih yushih requested a review from Nebyt October 25, 2022 09:40
@Nebyt Nebyt self-requested a review October 25, 2022 12:20
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman self-requested a review October 28, 2022 11:11
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor

The change is tested and is getting merged. The tests are getting fixed in a separate branch.

@vsubhuman vsubhuman merged commit e794694 into develop Dec 6, 2022
@vsubhuman vsubhuman deleted the yushi/yoroi-lib-utxo branch December 6, 2022 14:28
@vsubhuman vsubhuman mentioned this pull request Dec 6, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants