Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for change currency pairing #2948

Merged
merged 25 commits into from
Feb 2, 2023

Conversation

cmerloglb
Copy link
Contributor

No description provided.

@cmerloglb cmerloglb force-pushed the e2e-tests-currency-functionality branch from d8f1416 to 4dbf69a Compare August 3, 2022 20:28
@cmerloglb cmerloglb requested a review from Nebyt August 3, 2022 20:29
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to add to checks for all available fiats.
It necessary to avoid long selectors, such selector a wick point in tests. Please change it https://github.com/Emurgo/yoroi-frontend/pull/2948/files#diff-76b2890a5d6f64c0e0237af42bf8823aa0f1ddd81a2667ef32ac5258a9d91f4fR5

@cmerloglb cmerloglb force-pushed the e2e-tests-currency-functionality branch from 8c22e16 to f3577bc Compare August 4, 2022 20:52
@cmerloglb cmerloglb marked this pull request as draft August 8, 2022 01:15
Nebyt and others added 14 commits August 8, 2022 13:19
# Conflicts:
#	packages/yoroi-extension/features/mock-chain/mockCardanoImporter.js
#	packages/yoroi-extension/features/pages/walletTransactionsPage.js
#	packages/yoroi-extension/features/step_definitions/common-steps.js
#	packages/yoroi-extension/features/step_definitions/general-settings-steps.js
#	packages/yoroi-extension/features/step_definitions/settings-ui-steps.js
#	packages/yoroi-extension/features/step_definitions/tx-history-steps.js
#	packages/yoroi-extension/features/step_definitions/wallet-delegation-steps.js
#	packages/yoroi-extension/features/support/helpers/common-constants.js
@Nebyt Nebyt marked this pull request as ready for review November 3, 2022 13:18
@Nebyt Nebyt self-requested a review November 16, 2022 09:44
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

…-functionality

# Conflicts:
#	packages/yoroi-extension/features/mock-chain/mockCardanoImporter.js
#	packages/yoroi-extension/features/step_definitions/common-steps.js
@vsubhuman vsubhuman merged commit ed56b09 into develop Feb 2, 2023
@vsubhuman vsubhuman deleted the e2e-tests-currency-functionality branch February 2, 2023 16:37
@vsubhuman vsubhuman added this to the 4.19.0 milestone Feb 2, 2023
@vsubhuman vsubhuman mentioned this pull request Feb 8, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants