Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate browser logs #2977

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Separate browser logs #2977

merged 8 commits into from
Sep 14, 2022

Conversation

cmerloglb
Copy link
Contributor

No description provided.

@cmerloglb cmerloglb changed the base branch from develop to denis/ci_for_smoke_tests August 24, 2022 20:45
cmerloglb
cmerloglb commented Aug 24, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@cmerloglb cmerloglb requested a review from Nebyt August 25, 2022 00:43
Nebyt
Nebyt requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@Nebyt Nebyt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes:

  1. The structure of logs should be like this:
  • testRunsData_[browser]
    • testsLogs
      • testLogs
      • ...
    • mockAndWMLogs
    • trezorEmulatorLogs
    • webDriverLogs
  1. Remove creating the old tests logs directory in the BeforeAll hook
  2. If you rerun the same test locally you receive the error
file already exists, mkdir './testRunsData_cardanoMockServerLogs'
  1. Removed unused variables in constants
  2. Move creating loggers into the first Before hook. It give us readable names for logs

Nebyt
Nebyt reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@Nebyt Nebyt self-requested a review August 25, 2022 18:18
@vsubhuman vsubhuman merged commit 4a870ef into denis/ci_for_smoke_tests Sep 14, 2022
@vsubhuman vsubhuman deleted the separate-browser-logs branch September 14, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebyt Nebyt Nebyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmerloglb @Nebyt @vsubhuman