Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed tests for ledger devices #3026

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Removed tests for ledger devices #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 0 additions & 132 deletions packages/yoroi-extension/features/hardware.feature
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/yoroi-extension/features/mock-ledger-connect/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ import {
StakeCredentialParamsType,
} from '@cardano-foundation/ledgerjs-hw-app-cardano';

/*
Mocking a ledger device is not possible anymore after this update https://github.com/Emurgo/yoroi-frontend/pull/2896
*/

type WalletInfo = {|
rootKey: RustModule.WalletV4.Bip32PrivateKey;
serial: GetSerialResponse,
Expand Down
1 change: 1 addition & 0 deletions packages/yoroi-extension/features/step_definitions/common-steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ async function setLedgerWallet(client, serial) {
.catch(err => done(err));
}, serial);
}
// deprecated
Given(/^I connected Ledger device ([^"]*)$/, async function (serial) {
this.webDriverLogger.info(`Step: I connected Ledger device ${serial}`);
await setLedgerWallet(this, serial);
Expand Down
5 changes: 4 additions & 1 deletion packages/yoroi-extension/features/step_definitions/hardware-steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { errorBlockComponent, primaryButton } from '../pages/commonDialogPage';
import { walletNameInput } from '../pages/restoreWalletPage';
import { verifyAddressButton, verifyAddressHWButton } from '../pages/walletReceivePage';

// deprecated
When(/^I select a Byron-era Ledger device$/, async function () {
await this.click(connectHwButton);
await this.waitForElement(pickUpCurrencyDialog);
Expand All @@ -30,6 +31,7 @@ When(/^I select a Byron-era Ledger device$/, async function () {
await this.click(ledgerWalletButton);
await this.click(byronEraButton);
});
// deprecated
When(/^I select a Shelley-era Ledger device$/, async function () {
await this.click(connectHwButton);
await this.waitForElement(pickUpCurrencyDialog);
Expand All @@ -38,6 +40,7 @@ When(/^I select a Shelley-era Ledger device$/, async function () {
await this.click(ledgerWalletButton);
await this.click(shelleyEraButton);
});
// deprecated
When(/^I restore the Ledger device$/, async function () {
await this.waitForElement(checkDialog);
await this.click(primaryButton);
Expand Down Expand Up @@ -95,7 +98,7 @@ When(/^I see the verification address "([^"]*)"$/, async function (expectAddress
When(/^I see the derivation path "([^"]*)"$/, async function (path) {
await this.waitUntilText(derivationField, path);
});

// deprecated
Then(/^I verify the address on my ledger device$/, async function () {
await this.click(verifyAddressHWButton);
await this.waitDisable(verifyAddressHWButton); // disable when communicating with device
Expand Down