Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after Yoroi-lib change #3069

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Fix tests after Yoroi-lib change #3069

merged 2 commits into from
Dec 8, 2022

Conversation

yushih
Copy link
Collaborator

@yushih yushih commented Dec 7, 2022

@yushih yushih requested a review from vsubhuman December 7, 2022 07:18
vsubhuman
vsubhuman approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yushih !

@vsubhuman vsubhuman modified the milestones: 4.18.0, 4.19.0 Dec 7, 2022
@vsubhuman vsubhuman changed the base branch from develop to release/4.18 December 8, 2022 07:09
@vsubhuman vsubhuman modified the milestones: 4.19.0, 4.18.0 Dec 8, 2022
@vsubhuman vsubhuman merged commit 4b18f44 into release/4.18 Dec 8, 2022
@vsubhuman vsubhuman deleted the yushi/fix-yoroi-lib-test branch December 8, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yushih @vsubhuman