feat: format big numbers using Intl api when rendered on screen
#3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the big diff is because of the formatted file that was not formated |
|
SonarQube Quality Gate
|
vsubhuman
requested changes
Apr 19, 2023
There was a problem hiding this comment.
@neuodev , plz check the comment about the locale and also please roll back the formatting changes that are not related to the intended change, it becomes very hard to review and make sure I don't miss any of the changes that are actually important in the PR.
We can have formatting fixes as separate PRs that are not intended to have any logic changes.
packages/yoroi-extension/app/components/wallet/assets/TokenList.js
Outdated
Show resolved
Hide resolved
neuodev
force-pushed
the
Ahmed/format-nums
branch
from
cb75fc9
to
6f32ad4
Compare
neuodev
force-pushed
the
Ahmed/format-nums
branch
from
6f32ad4
to
d575546
Compare
vsubhuman
approved these changes
Jun 16, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format token amount:
100000==>100,000Screenshot