Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(send-tx): update transaction success dialog layout #3227

Merged
merged 8 commits into from
Jun 20, 2023
Merged

fix(send-tx): update transaction success dialog layout #3227

merged 8 commits into from
Jun 20, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Jun 1, 2023 •
edited
Loading

Preview

Screenshot 2023-06-12 at 6 44 07 PM

@neuodev neuodev self-assigned this Jun 1, 2023
@neuodev
Copy link
Contributor Author

neuodev commented Jun 1, 2023

[autoscirpt] Jira Ticket: Transaction success dialog design is outdated

@vsubhuman vsubhuman added this to the 4.22.0 milestone Jun 5, 2023
@neuodev neuodev marked this pull request as draft June 5, 2023 11:01
@neuodev neuodev marked this pull request as ready for review June 12, 2023 15:44
@neuodev neuodev requested review from vsubhuman and Nebyt June 12, 2023 15:45
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vsubhuman
vsubhuman reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit a9973e8 into develop Jun 20, 2023
@vsubhuman vsubhuman deleted the fix/YOEXT-614/tx-success-dialog branch June 20, 2023 11:12
yushih pushed a commit that referenced this pull request Jun 22, 2023
@vsubhuman @yushih
Merge pull request #3227 from Emurgo/fix/YOEXT-614/tx-success-dialog
7f4575d 
fix(send-tx): update transaction success dialog layout
@vsubhuman vsubhuman mentioned this pull request Jun 23, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@Nebyt Nebyt Awaiting requested review from Nebyt

Assignees

@neuodev neuodev

Labels
None yet
Projects
None yet
Milestone
4.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neuodev @vsubhuman