Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector .getCollateral parameters fix #3279

Merged

Conversation

vsubhuman
Copy link
Contributor

Both .getCollateral and the deprecated .getCollateralUtxos functions can now be called with one of these parameters:

  1. A number as a number
  2. A number as a string
  3. An object { amount: string | number } (proper CIP30)
  4. A CBOR encoding of type Value
  5. No parameter (in which case the default max allowed value of 5 ADA will be used)

…, with a direct number or string, with a cbor `Value`, or with a `{ amount: string " number" }` object
@vsubhuman vsubhuman added this to the 4.22.500 milestone Sep 7, 2023
@neuodev
Copy link
Contributor

neuodev commented Sep 7, 2023

[autoscirpt] Jira Ticket: Broken getCollateralUtxos

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition E Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@vsubhuman vsubhuman merged commit 37dbb2e into release/4.22.500 Sep 7, 2023
2 of 3 checks passed
@vsubhuman vsubhuman deleted the fix/YOEXT-535/connector-collateral-parameter-fix branch September 7, 2023 23:24
@vsubhuman vsubhuman mentioned this pull request Sep 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants