Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add brave tests to ci pipeline #376

Merged
merged 8 commits into from
Apr 1, 2019
Merged

Feature/add brave tests to ci pipeline #376

merged 8 commits into from
Apr 1, 2019

Conversation

rcmorano
Copy link
Contributor

@rcmorano rcmorano commented Apr 1, 2019

No description provided.

SebastienGllmt
SebastienGllmt suggested changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@SebastienGllmt SebastienGllmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this so that we only test Brave when making a PR to master? I don't want to slow down every single CI build on develop for a test that should basically always pass

@rcmorano
Copy link
Contributor Author

rcmorano commented Apr 1, 2019

I think that last change should do it :)

@SebastienGllmt SebastienGllmt merged commit 1e9ef2e into develop Apr 1, 2019
@SebastienGllmt SebastienGllmt deleted the feature/add-brave-tests-to-ci-pipeline branch April 1, 2019 17:27
This was referenced Apr 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastienGllmt SebastienGllmt SebastienGllmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcmorano @SebastienGllmt