-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/add flags to general settings language dropdown #378
feature/add flags to general settings language dropdown #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @codybutz!
All looks good, however, as we're moving towards aligning the visual identity of mobile app and extension, it would be great if we don't diverge on the flags. Could you replace the flags with the ones we use in the mobile app? https://github.com/Emurgo/yoroi-mobile/tree/develop/src/assets/img/flags
You will see that German and French flags are currently missing. I'll ask the designer to get those for you today.
Thanks for your first PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Cody! Instead of those PNGs, here are the SVGs you can drop in to use for flags:
flags-compressed.zip
@ebeloded I have made the requested changes. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds FlagLabel widget that allows reuse of the Flag dropdowns
I have went ahead and pushed those changes. I made a new widget called "FlagLabel" so that the labels can be reused between GeneralSettings and LanguageSelectionForm. I also updated the CSS to use flex, just because it's better :) |
Thanks, @codybutz! Nice job on your first PR. Keep those coming ;) |
Ref #359
Adds icons for each language in the General Settings language dropdown.
Icons from: https://www.iconfinder.com/iconsets/flags-37 (Free for commercial use)
Icons can easily be replaced in app/assets/images/flags/
Please feel free to give any feedback!