Chore: lint: eliminate eslint warnings

.eslintrc

@@ -66,7 +66,7 @@
     "no-multi-assign": 0,
     "no-unneeded-ternary": ["error", { "defaultAssignment": true }],
     "prefer-template": 0,
-    "no-unused-vars": 1,
+    "no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
     "no-trailing-spaces": 1,
     "padded-blocks": 0,
     "no-undef": 1,

app/App.js

@@ -59,8 +59,9 @@ class App extends Component<{
     const themeVars = Object.assign(
       stores.profile.currentThemeVars,
       {
-        // show wingdings on dev builds when no font is set to easily find missing font bugs
-        // however, on production, we use Times New Roman which looks ugly but at least it's readable.
+        // show wingdings on dev builds when no font is set to easily find
+        // missing font bugshowever, on production, we use Times New Roman
+        // which looks ugly but at least it's readable.
         '--default-font': environment.isDev() ? 'wingdings' : 'Times New Roman',
       }
     );

app/api/ada/index.js

@@ -997,7 +997,7 @@ export default class AdaApi {
   }
 
   async getSelectedExplorer(
-    request: GetSelectedExplorerRequest
+    _request: GetSelectedExplorerRequest
   ): Promise<GetSelectedExplorerResponse> {
     Logger.debug('AdaApi::getSelectedExplorer called');
     try {

app/components/settings/SettingsLayout.js

@@ -11,10 +11,6 @@ type Props = {|
 
 @observer
 export default class SettingsLayout extends Component<Props> {
-  static defaultProps = {
-    children: undefined
-  };
-
   render() {
     const { menu, children } = this.props;
     return (

app/components/settings/categories/general-setting/ThemeSettingsBlock.js

@@ -9,7 +9,6 @@ import styles from './ThemeSettingsBlock.scss';
 import { THEMES } from '../../../../themes';
 import type { Theme } from '../../../../themes';
 import ThemeThumbnail from '../display/ThemeThumbnail';
-import environment from '../../../../environment';
 
 const messages = defineMessages({
   themeLabel: {

app/components/wallet/hwConnect/trezor/HelpLinkBlock.js

@@ -5,7 +5,6 @@ import { defineMessages, intlShape } from 'react-intl';
 import SvgInline from 'react-svg-inline';
 
 import externalLinkSVG from '../../../../assets/images/link-external.inline.svg';
-import { ProgressInfo } from '../../../../types/HWConnectStoreTypes';
 import styles from '../common/HelpLinkBlock.scss';
 
 const messages = defineMessages({

app/containers/LoadingPage.js

@@ -57,7 +57,7 @@ export default class LoadingPage extends Component<InjectedProps> {
       // eslint-disable-next-line jsx-a11y/anchor-is-valid
       <a
         href="#"
-        onClick={event => downloadLogs()}
+        onClick={_event => downloadLogs()}
       >
         {intl.formatMessage(globalMessages.downloadLogsLink)}
       </a>

app/containers/settings/Settings.js

@@ -65,7 +65,7 @@ export default class Settings extends Component<InjectedContainerProps> {
         classicTheme={profile.isClassicTheme}
       >
         <SettingsLayout menu={menu}>
-          {children}
+          {children || null /* the "|| null" part keeps flow happy */}
         </SettingsLayout>
       </Layout>
     );

app/themes/prebuilt/YoroiClassic.js

@@ -298,7 +298,7 @@ export default {
   '--theme-system-error-overlay-text-color': '#fafbfc',
 
   '--theme-topbar-active-item-bottom-border': '5px solid #daa49a',
-  '--theme-topbar-active-item-top-border': '5px solid transparent',  
+  '--theme-topbar-active-item-top-border': '5px solid transparent',
   '--theme-topbar-category-text-color': '#fafbfc',
   '--theme-topbar-background-color-gradient-start': topbarGradient.start,
   '--theme-topbar-background-color-gradient-end': topbarGradient.end,

app/themes/prebuilt/YoroiModern.js

@@ -377,7 +377,7 @@ export default {
   '--theme-wallet-add-option-dialog-item-title-color': '#2B2C32',
   '--theme-wallet-add-option-dialog-item-learn-more-block-bg-color': '#F5F7F9',
   '--theme-wallet-add-option-dialog-item-learn-more-button-color': '#ADAEB6',
-  '--theme-wallet-add-option-dialog-item-learn-more-button-bg-color': '#F5F7F9',  
+  '--theme-wallet-add-option-dialog-item-learn-more-button-bg-color': '#F5F7F9',
   '--theme-wallet-add-translucent-color': 'rgba(255, 255, 255, 0.5)',
   '--theme-wallet-add-footer-text-color': '#353535',