This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Fix dependency declaration of Prometheus #4699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is battle between Golang authors and Prometheus authors (probably some others as well).
Golang requires semantic versioning, and Prometheus doesn't want submit to those rules:
You can still put a commit has into the go.mod file as version, but that gets translated to into a version from the past (for 2.15.2 prometheus this will resolve into 2.3.x or 1.8.x).
The solution to all of this insanity is, to declare the version you had in mind in the "requires" section. And then add a mapping entry into the "replace" section, pointing to the actual version, using a commit hash and the "v0.0.0" version.
Type of change
RantDescription
Checklist
./documentation/design