Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility NOT to push #86

Closed
kbsali opened this issue Nov 8, 2020 · 4 comments
Closed

Add the possibility NOT to push #86

kbsali opened this issue Nov 8, 2020 · 4 comments
Assignees
Labels
good first issue Good for newcomers type: feature New feature or feature request

Comments

@kbsali
Copy link

kbsali commented Nov 8, 2020

Hi,

thanks for this action, pretty handy.
I just have a little request : I have a use case where I run a series of tasks and on every step I would like to commit the changed/new files, but I only would like to push at the very end of the process. So in my case it would make sense to have an option to skip the git push on specific tasks.
What do you think?

@EndBug EndBug self-assigned this Nov 9, 2020
@EndBug EndBug added the type: feature New feature or feature request label Nov 9, 2020
EndBug added a commit that referenced this issue Nov 11, 2020
@EndBug EndBug added the good first issue Good for newcomers label Nov 11, 2020
@EndBug
Copy link
Owner

EndBug commented Nov 11, 2020

Hi, thanks for the issue! I've added the feature to the action: you'll now need to use the push: false option.
I'll publish this soon as a new minor version.

@all-contributors please add @kbsali for their idea

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @kbsali! 🎉

@EndBug
Copy link
Owner

EndBug commented Nov 11, 2020

Ok, I've published everything under version v5.2.0 (also available via v5 and latest)
Thank you again for the issue, I'll close it for now.

@EndBug EndBug closed this as completed Nov 11, 2020
@kbsali
Copy link
Author

kbsali commented Nov 13, 2020

awesome, thanks a lot @EndBug (and thank you twice for including me in the list of contributors... not sure it is deserved though! 😅 ) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants