-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to use --signoff with git commit #46
Conversation
Signed-off-by: pvogt09 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR, but I have some questions:
- I've run a couple of tests with your code, and it doesn't seem to commit correctly. Could you link me to the tests you ran so that I can confront them?
- The new option would only add an argument to the
git add
command, wouldn't it be easier to just add it in theadd
option (likesrc --signoff
)? If not, are there any issues in doing so?
I know that the --force
parameter has its own option in this action, but I feel like it would be better to just add a field that you can use to put your custom options, if that can't already be achieved by using the add
field.
I have tested it by changing the The aim of the |
Sorry, my bad:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem was caused by the fact that you used double quotes with the sign off variable.
I've also refactored the code to make it look like the add
function.
You're welcome to give it a check, if that works for you I'll publish it in the next minor version ;)
I am ok with the changes. Thank you for the help. |
@all-contributors please add @pvogt09 for code |
I've put up a pull request to add @pvogt09! 🎉 |
Ok, you can find the new feature in version Thanks again for your contribution ✨ |
This PR adds the ability to
--signoff
the created commit by introducing a new optionssignoff
.