fix: support root-relative URLs in EsButton #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
href
orto
prop, would pass those to NuxtLink. NuxtLink will externally navigate with a full URL like https://www.google.com, but if provided a root-relative URL like /market/start/, it will attempt to internally navigate and result in a 404, even though that URL does exist on our domain.href
is provided, we use an<a>
tag, and ifto
is provided, we use a NuxtLink. This allows downstream applications to decide whether they need an internal or external navigation on a link, rather than the design system forcing one upon them that may not work.π₯Ό Testing
π§ Feedback Requested / Focus Areas