Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved vuelidate utils from es-ds-docs to es-ds-components so EsZipCodeForm won't break #1555

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ericdouglaspratt
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • EsZipCodeForm uses consts like vuelidateKeys and vuelidateMaxLength - these consts are not defined in es-ds-components, so I was getting downstream errors of "vuelidateKeys is undefined" when trying to use EsZipCodeForm
  • I found these consts defined in utils files in es-ds-docs, which is why VS Code thought they were available even though they weren't. I've moved them into es-ds-components so they'll be exported along with EsZipCodeForm

🥼 Testing

  • Tested locally on es-cms-pages homepage with PageCtaBannerV2

🧐 Feedback Requested / Focus Areas

  • Overall

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Oct 23, 2024

Copy link
Contributor

@lgeggleston lgeggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ericdouglaspratt ericdouglaspratt merged commit 37758ec into esds-3.0-vue3-primevue Oct 23, 2024
1 check passed
@ericdouglaspratt ericdouglaspratt deleted the ced-1900-vuelidate-fix branch October 23, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants