Formalize most public API #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozufozu
requested changes
Jul 21, 2024
Comment on lines
+37
to
+46
| if (level == null) { | ||
| if (state == null) { | ||
| state = Blocks.AIR.defaultBlockState(); | ||
| } | ||
| FabricOriginBlockAndTintGetter originLevel = objects.level; | ||
| originLevel.originBlockState(state); | ||
| level = originLevel; | ||
| } else if (state == null) { | ||
| state = level.getBlockState(BlockPos.ZERO); | ||
| } |
There was a problem hiding this comment.
This seems like complex behavior to hide in the impl. Somewhat related, perhaps there should be explicit methods for defaultLevel and defaultBlockState in the common builder
There was a problem hiding this comment.
All builder methods for all three types of builders are optional and thus have default values. Would it be better to add default*() methods for all properties or accept nullable parameters, where null means default?
common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/PartialModel.java
Outdated
Show resolved
Hide resolved
- Add Engine#onLightUpdate; remove LightUpdateHolder and backend/ClientChunkCacheMixin - Add Effect#level - Add VisualizationHelper#queueAdd and #queueRemove for Effects - Fix PartialModel not assigning bakedModel field when populating on init - Fix PartialModel.ALL using weak keys instead of weak values - Make Simple*Visualizer and corresponding inner Builder classes final - Restore FlatLit#light overload that accepts block and sky light values separately - Add AbstractBlockEntityVisual#relight overloads that accept Iterator and Iterable - Reorganize classes in impl.vizualization
- Move TaskExecutor#sync* methods to TaskExecutorImpl - Move Flag and RaisePlan to impl - Remove TaskExecutor#scheduleForMainThread and #isMainThread methods - Remove SyncedPlan - Add Engine#setupRender - Remove TaskExecutor parameters from Engine#render* methods - Convert Engine$CrumblingBlock into an interface - Unmark RenderContext as NonExtendable to allow fulfilling the purpose described in the doc of VisualizationManager#renderDispatcher
- Lazily initialize MaterialShaderIndices - Rename MaterialShaders#*Shader to #*Source - Move BackendImplemented to api.backend package
|
I will merge the PR now as there are a lot of changes and waiting for more minor changes is not worth the merge conflicts with other mainline changes that this will cause.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request performs many, mostly minor, changes across most public API to make it nicer to use and more stable in general.