Add actor name option #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
EnricoMi
reviewed
May 30, 2023
|
This has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my org projects, I can not use
GITHUB_TOKENfor API rate limiting issues. So I used GitHub App to authenticate this action.But the issue in this approach is the action creates a new comment for each run which bloats the PR (I run 3 workflows with this action for each commit, for 10 commits, it creates 30 comments).
In this PR, we are adding support for optionally providing
actor_name, which will be used to find the correct comment to be replaced.I am not totally sure about the naming of this new variable. Please suggest if this needs to be changed.
And thanks for this awesome action.