Add app gateway SKU variables #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satenderrathee
approved these changes
Oct 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updated AppGateway to SKU StandardV2. This meant a priority needed to be added to rules and the Public IP address needed to be set as static with a standard SKU, https://thomasthornton.cloud/2023/12/12/resolving-terraform-error-applicationgatewayinvalidpublicipsku-application-gateway-sku-mismatch-with-public-ip/.
Added pick_host_name_from_backend_http_settings and host_name variables because we want to set these when deploying Azure Container Apps
🤔 Why
Standard SKU is not supported