feat(errors): show error messaging as banner on failed submissions #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 26, 2024 13:41
hannasage
requested review from
benjaminpaige,
13bfrancis,
mdial89f and
pkim-gswell
hannasage
added
status: READY
mdial89f
approved these changes
Mar 28, 2024
hannasage
added
In Testing
|
🎉 This PR is included in version 1.5.0-val.24 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To introduce a banner that displays errors provided by the API when submitting a form.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-27443
Approach
Use our already established alert context to display relevant info from within our catch block on submission.
Assorted Notes/Considerations/Learning
Brian's work setting up the error banner display tooling in the new actions pages made it the quickest change despite the learning curve from the old verbose pattern. Worth it in my opinion!