-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch darkly perform intake): add launch darkly logic to label mappers #485
Conversation
…e the actual function
… changelog events. in addition, some of the events are misconstructed. we may want to maintain main from the more consistently structured 'package' events, and populate the changelog from the sumbit events.
…s process them all.
…e, but we dont need it, and hard deletes are something were simply not going to do... so i think less may be more here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move where this logic occurs?
https://github.com/Enterprise-CMCS/macpro-mako/blob/juliet/src/packages/shared-utils/package-actions/rules.ts#L99
^^ This is the rule that governs if the action is available or not. So maybe something like
check: (checker, user) => isCmsWriteUser(user) && checker.needsIntake && <boolean that indicates its enabled by a feature flag, or at least not disabled>
I think that's a better place to add the condition
Further, a question: you think it'd be possible and/or wise to resolve all feature flags in a single file? something so we don't need to useLDClient everywhere we want to check for a feature flag. Not sure.
@mdial89f Is there a way to pull aws keys in the shared utils package? I know the way we've been doing it has been through serverless in the other services, should we be going about it in a different way here? As for your second question, this is the way manage care review is doing it, but I can do some more research on alternative paths to clean it up |
Purpose
Add show hide logic of perform intake logic with launch darkly flags