add mac support

[alse]

@Envek thanks for putting this together!

I made some updates to add mac support.

Recording the screen and webcam works, but the live preview doesn't show up. Any idea why? log_output.txt

[Envek]

Wow! Cool!

Maybe preview window doesn't work because of displayId is different on MacOS (can't remember where I've got this display1 from)? Or, perhaps, window.getNativeHandle() returns something different?

obs-studio-node-example/obsRecorder.js

Lines 241 to 248 in 2ab50a3

	const displayId = 'display1';
	function setupPreview(window, bounds) {
	osn.NodeObs.OBS_content_createSourcePreviewDisplay(
	window.getNativeWindowHandle(),
	scene.name, // or use camera source Id here
	displayId,
	);

[Envek]

getAudioDevices is being used to get both input and output sources, so it is better to detect of OS-specific types in places that call this function. And here just use type and subtype. Btw why uuid() is used here instead of provided subtype?

[alse]

Good point, I reverted that change

[alse]

Wow! Cool!

Maybe preview window doesn't work because of displayId is different on MacOS (can't remember where I've got this display1 from)? Or, perhaps, window.getNativeHandle() returns something different?

Hmm I think the display1 can be an arbitrary string. getNativeHandle is undefined on mac. I'll post an update if I find anything

[alse]

@Envek I'm also seeing a problem with slow frame rates when streaming to the virtual camera. Recording to disk is smooth. Do you know what could be causing it?

This warning comes up:
[swscaler @ 0x11d979000] Warning: data is not aligned! This can lead to a speed loss

// osn.NodeObs.OBS_service_installVirtualCamPlugin()

osn.NodeObs.OBS_service_createVirtualWebcam('Streamlabs OBS Virtual Webcam - Example');
osn.NodeObs.OBS_service_startVirtualWebcam()

osn.NodeObs.OBS_service_stopVirtualWebcam();
osn.NodeObs.OBS_service_removeVirtualWebcam();

[Envek]

No, I have no idea. I think that it can be internal issue in obs-studio-node (probably very low-level one). So, please open an issue in their issue tracker at https://github.com/stream-labs/obs-studio-node/issues

[alse]

It works well when running the latest streamlabs-obs with the same obs-studio-node, so it must be related to this setup. I'll keep digging, thanks!

[Envek]

Tested it on Windows: it works. LGTM at this stage. Hope that you'll find solution for preview.

[psd-coder]

Hey! I can't run it on my mac

[Envek]

That one looks like #18 (comment)

[alse]

@psd-coder sure you're on the right branch? Looks like it's using the windows input types, is process.platform "darwin"?

[psd-coder]

@alse You are right! My bad, I forgot to checkout branch... it works! but needed to be fixed uuid require

[alse]

Great! What was wrong with the uuid require?

[psd-coder]

I got Error: Cannot find module 'uuid/v4' until changed it to const { v4: uuid } = require('uuid'); from const uuid = require('uuid/v4')

[chfeizy]

@alse Can the mac version of obs-studio-node run?

[alse]

@psd-coder thanks, I updated the uuid require

@chfeizy yes, it runs on mac for me. Make sure you start it from a native terminal, not vscode

[chfeizy]

@alse I'm run with mac terminal, the display is not show, the record is success

[chfeizy]

@alse

[alse]

@chfeizy the preview doesn't work on mac yet

[Envek]

Thank you very much! Let's use it as is and fix known issues later (maybe by someone else)