feat(flag): refactor separateArgs function #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor separateArgs to reduce cognitive complexity and improve maintainability: - Extract logic into separate functions: buildFlagsWithArgsMap, handleLongFlag, handleShortFlag - Simplify main loop using switch statement - Improve code readability Add comprehensive unit tests: - Test separateArgs function with various input scenarios - Create separate tests for buildFlagsWithArgsMap, handleLongFlag, and handleShortFlag - Ensure proper handling of different flag types and edge cases This refactoring addresses the high cognitive complexity issue in the separateArgs function while maintaining its functionality. The added tests improve code reliability and make future modifications easier and safer.
Improve the separateArgs function to handle complex cases with double dashes and multiple flags. This change allows for more flexible and accurate parsing of command-line arguments.
- Refactor separateArgs function to handle edge cases and improve readability
- Add support for multiple occurrences of double dash ('--')
- Enhance handling of short flags with attached values
- Update tests to cover new complex cases with double dashes
- Add debug print statement to display final arguments
Equationzhao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the separateArgs function to improve argument parsing and handling.