-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bunch of new maps #9
Conversation
nice! 16 by my count!! i see an issue tho, the bottom of every map should contain a commented out chunk of the source and event ID that you are mapping, in case people want to tweak it. is it too much trouble to track down the eventdata for each of these and update the XML? |
No. Just the event data or userdata block. That's all that really changes
and is affected by the xpath queries.
…On Sun, Jun 9, 2019, 9:03 AM Mike Pilkington ***@***.***> wrote:
I put the pertinent event data at the bottom of each one. Do you want the
entire event?
[image: image]
<https://user-images.githubusercontent.com/5453480/59159288-15117c00-8a8d-11e9-8ce1-46b52b03e501.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9?email_source=notifications&email_token=ABARKJUTTWUDBPIR7C2EBADPZT5S7A5CNFSM4HWIU7PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIJV6I#issuecomment-500210425>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABARKJQTGMMYC4EG4M27UH3PZT5S7ANCNFSM4HWIU7PA>
.
|
ok, so that is in each one. I made sure to include that. |
although I think I see the confusion. looks like the Application Experience EIDs 500 & 505 have the same example. That's because I happened to notice on my machine that 505 has the exact same data as 500, which came from the https://github.com/sbousseaden repo. I can fix that. Maybe merge these as-is and then I'll fix the 505 with an example from my machine? |
these look fine now. |
No description provided.