Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunch of new maps #9

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Conversation

mpilking
Copy link
Contributor

@mpilking mpilking commented Jun 9, 2019

No description provided.

@EricZimmerman
Copy link
Owner

nice! 16 by my count!!

i see an issue tho, the bottom of every map should contain a commented out chunk of the source and event ID that you are mapping, in case people want to tweak it.

is it too much trouble to track down the eventdata for each of these and update the XML?

@mpilking
Copy link
Contributor Author

mpilking commented Jun 9, 2019

I put the pertinent event data at the bottom of each one. Do you want the entire event?

image

@EricZimmerman
Copy link
Owner

EricZimmerman commented Jun 9, 2019 via email

@mpilking
Copy link
Contributor Author

mpilking commented Jun 9, 2019

ok, so that is in each one. I made sure to include that.

@mpilking
Copy link
Contributor Author

mpilking commented Jun 9, 2019

although I think I see the confusion. looks like the Application Experience EIDs 500 & 505 have the same example. That's because I happened to notice on my machine that 505 has the exact same data as 500, which came from the https://github.com/sbousseaden repo. I can fix that. Maybe merge these as-is and then I'll fix the 505 with an example from my machine?

@mpilking
Copy link
Contributor Author

mpilking commented Jun 9, 2019

Here's what a 505 looks like. Basically identical to the 500 (for some reason).

image

@EricZimmerman
Copy link
Owner

these look fine now.

@EricZimmerman EricZimmerman merged commit f2d6766 into EricZimmerman:master Jun 9, 2019
AndrewRathbun added a commit that referenced this pull request Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants