Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path_avatar and fix validation #30

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add path_avatar and fix validation #30

merged 2 commits into from
Oct 23, 2023

Conversation

mako321
Copy link
Member

@mako321 mako321 commented Oct 19, 2023

Close #29

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (63502cf) 96.47% compared to head (ef628d7) 96.48%.
Report is 1 commits behind head on main.

❗ Current head ef628d7 differs from pull request most recent head 05eb04a. Consider uploading reports for the commit 05eb04a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #30      +/-   ##
============================================
+ Coverage     96.47%   96.48%   +0.01%     
  Complexity       74       74              
============================================
  Files            22       22              
  Lines           255      256       +1     
============================================
+ Hits            246      247       +1     
  Misses            9        9              
Files Coverage Δ
src/Http/Resources/UserExportResource.php 100.00% <100.00%> (ø)
src/Import/AbstractUserImport.php 96.96% <100.00%> (ø)
src/Services/CsvUserService.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qunabu qunabu merged commit 16a5069 into main Oct 23, 2023
6 checks passed
@qunabu qunabu deleted the bugfix/issue-29 branch October 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing users not working but removes every profile picture
4 participants