Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/star 951 #10

Merged
merged 19 commits into from
Nov 9, 2022
Merged

Feature/star 951 #10

merged 19 commits into from
Nov 9, 2022

Conversation

HerbertIV
Copy link
Contributor

No description provided.

@gitguardian
Copy link

gitguardian bot commented Nov 9, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
2597801 Generic High Entropy Secret 4a6434e config/jitsi.php View secret
2597801 Generic High Entropy Secret b7f54b3 config/jitsi.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #10 (a3b6af3) into main (ac18943) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #10      +/-   ##
============================================
+ Coverage     96.02%   96.05%   +0.02%     
  Complexity       54       54              
============================================
  Files            10       10              
  Lines           151      152       +1     
============================================
+ Hits            145      146       +1     
  Misses            6        6              
Impacted Files Coverage Δ
src/Providers/SettingsServiceProvider.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qunabu qunabu merged commit 2cd44aa into main Nov 9, 2022
@qunabu qunabu deleted the feature/STAR-951 branch November 9, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants