Add starategy mode for jaas mode jitsi #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
============================================
- Coverage 98.38% 96.02% -2.37%
- Complexity 21 54 +33
============================================
Files 5 10 +5
Lines 62 151 +89
============================================
+ Hits 61 145 +84
- Misses 1 6 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qunabu
requested changes
Nov 4, 2022
src/Enum/JitsiEnum.php
Outdated
| @@ -72,4 +72,6 @@ class JitsiEnum extends Enum | |||
| 'ā' => 'a', 'č' => 'c', 'ē' => 'e', 'ģ' => 'g', 'ī' => 'i', 'ķ' => 'k', 'ļ' => 'l', 'ņ' => 'n', | |||
| 'š' => 's', 'ū' => 'u', 'ž' => 'z', | |||
| ]; | |||
|
|
|||
| public const DEFAULT_MODE = 'jitsi'; | |||
There was a problem hiding this comment.
imho settings those kind of flags is a mistake
we have 4 options /modes:
- module is disabled
- module is enabled but no config data is put -> we're using public j instance https://meet.jit.si/
- module is enabled and
hostapp_id&app_secretare set -> we're using self hosted jisty - module is enabled and
jaas_package_statusjaas_host,aud,iss,kid&private_keyare set -> we're Jitsy as a Service (jaas)
Comment on lines
22
to
31
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.host', ['required', 'string']); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.app_id', ['nullable', 'string'], false); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.secret', ['nullable', 'string'], false); | ||
|
|
||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.jaas_package_status', ['required', 'string', 'in:' . implode(',', PackageStatusEnum::getValues())], false); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.jaas_host', ['required', 'string']); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.aud', ['required', 'string'], false); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.iss', ['required', 'string'], false); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.kid', ['required', 'string'], false); | ||
| AdministrableConfig::registerConfig(self::CONFIG_KEY . '.private_key', ['required', 'string'], false); |
There was a problem hiding this comment.
see comment above
actually none of this fields is required
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 2597801 | Generic High Entropy Secret | 4a6434e | config/jitsi.php | View secret |
| 2597801 | Generic High Entropy Secret | b7f54b3 | config/jitsi.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.