feat: Diff Tracking SP1 patches #665
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
commented
Aug 21, 2024
Comment on lines
+19
to
+24
| pub fn msm(p: &[G1Affine], s: &[ScalarField]) -> G1Affine { | ||
| let mut iter = p.iter().zip(s).filter(|(_, s)| !s.is_zero()); | ||
| let mut result = { | ||
| let (p, s) = iter.next().unwrap(); | ||
| let mut p = wrap_g1affine(p); | ||
| bn254_double_and_add(&mut p, s); |
There was a problem hiding this comment.
may i ask why we didn't use AffinePoint struct and the ::msm() directly from sp1-lib as suggested in https://github.com/EspressoSystems/zkrollup-integration/issues/21#issuecomment-2292645127?
There was a problem hiding this comment.
I saw this after I had these working implementations. I don't think it's necessary to follow their APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not meant to merge into
main!Keep this as a draft PR to track the changes made.